[
https://issues.apache.org/jira/browse/ROCKETMQ-111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900752#comment-15900752
]
ASF GitHub Bot commented on ROCKETMQ-111:
-----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/69
@vongosling I meant "If I were you, I would ..." :) Anyway, I don't see why
this pr can be merged if a unit test can be easily written. I think we have to
accept PRs with tests, except for the cases when they cannot be implemented.
Ok, then let's close this pr? and tests can be submitted in another one.
@yilingfeng I have a quick look, and here is what I think.
Better name the file `MessageClientIDSetterTest.java` and have tests for
`getNearlyTimeFromID()` etc. instead of implementing another method in your
unit test class.
> fix possible MQClientException when query message before today
> --------------------------------------------------------------
>
> Key: ROCKETMQ-111
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-111
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-commons
> Affects Versions: 4.0.0-incubating
> Reporter: Yiling Feng
> Assignee: Jixiang Jin
> Labels: build
> Fix For: 4.0.0-incubating
>
>
> Using "cal.set(Calendar.HOUR,0);" when query message before today which may
> result in :
> "org.apache.rocketmq.client.exception.MQClientException: CODE: 208 DESC:
> query message by key finished, but no message. "
> "HOUR" is used for the 12-hour clock.This will cause the start time of the
> query message to be greater than the creation time of the message.
> Implemenations:
> Using "HOUR_OF_DAY" instead of "HOUR"."HOUR_OF_DAY" is used for the 24-hour
> clock.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
