[
https://issues.apache.org/jira/browse/ROCKETMQ-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15900992#comment-15900992
]
ASF GitHub Bot commented on ROCKETMQ-134:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/72
You are right , but this is actually not a very big problem since though
the offset this round is not committed, the pull request for next round is
still continue so next time the offset will still committed.
If the consumer crashes at that moment, an unnecessary pull request will be
submitted, which is the what the problem actually is , but it is very minor.
Please firstly relate the JIRA in your descriptions.
For this PR, I don't suggest doing correctTags when pull list is empty
because it is always empty as long as there is no message.
If this issue should be solved, I suggest modify the pull result to
NO_MATCHED when pulling some message but filter by client by tag in method
`processPullResult`
//filter by client again and no messages left
if(msgListFilterAgain.isEmpty() && !msgList.isEmpty()) {
pullResultExt.setPullStatus(PullStatus.NO_MATCHED_MSG);
}
> the offset of message filter by tags may be not commit to broker
> ----------------------------------------------------------------
>
> Key: ROCKETMQ-134
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-134
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
> Affects Versions: 4.0.0-incubating
> Reporter: Jie.Tang
> Assignee: Xiaorui Wang
> Priority: Trivial
>
> when different string has a same hash code.the message commit offset of
> filtered message may be not commit to broker.
> for example:
> 1.consumer pull message from broker, broker return status FOUND and messages
> filter by tags hash code
> 2.consumer client get the messages and than processPullResult will filter
> message by tags.
> 3.PullCallback may get a pullResult which status is FOUND but messageList is
> empty.(filter by tags)
> but only NO_MATCHED_MSG and NO_NEW_MSG will correctTagsOffset
> we can't commit the right with status of FOUND(for messageList is empty).
> Is that so?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
