[
https://issues.apache.org/jira/browse/ROCKETMQ-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15942879#comment-15942879
]
ASF GitHub Bot commented on ROCKETMQ-138:
-----------------------------------------
Github user vongosling commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/75
If we remove it, all authentication fail will have one log, and this could
be possibly very often and fill up with the remoting log, which I do not think
it is good enough.
We can just keep it as the previous. We will introduce a new remoting
module in the 4.1 with seriously consideration about exception mechanism~
> Add AuthenticationException class to remove hard coded Aliyun authentication
> class
> ----------------------------------------------------------------------------------
>
> Key: ROCKETMQ-138
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-138
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-remoting
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
> Priority: Minor
>
> in NettyRemotingAbstract.java
> a hard coded aliyun class is used
> {code}
> catch (Throwable e) {
> if
> (!"com.aliyun.openservices.ons.api.impl.authority.exception.AuthenticationException"
> .equals(e.getClass().getCanonicalName())) {
> PLOG.error("process request exception", e);
> PLOG.error(cmd.toString());
> }
> {code}
> A common AuthenticationException should be added to identify Authentication
> failure. Developers can throw this exception so that remoting component can
> ignore it
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
