[
https://issues.apache.org/jira/browse/ROCKETMQ-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944437#comment-15944437
]
ASF GitHub Bot commented on ROCKETMQ-144:
-----------------------------------------
Github user zhouxinyu commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108325070
--- Diff: distribution/release.xml ---
@@ -1,19 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
- Licensed to the Apache Software Foundation (ASF) under one or more
- contributor license agreements. See the NOTICE file distributed with
- this work for additional information regarding copyright ownership.
- The ASF licenses this file to You under the Apache License, Version 2.0
- (the "License"); you may not use this file except in compliance with
- the License. You may obtain a copy of the License at
-
- http://www.apache.org/licenses/LICENSE-2.0
-
- Unless required by applicable law or agreed to in writing, software
- distributed under the License is distributed on an "AS IS" BASIS,
- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- See the License for the specific language governing permissions and
- limitations under the License.
+ ~ Licensed to the Apache Software Foundation (ASF) under one or more
--- End diff --
Hi,
The copyright format of `.xml` file is `<!-- -->`, instead of `<!-- ~ -->`.
> Aggregate distribution specific files to a new module
> -----------------------------------------------------
>
> Key: ROCKETMQ-144
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-144
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
>
> When running maven-assembly-plugin, it constantly warns and suggests to use a
> separate sub-module to aggregate packaging files, which are scattered in the
> parent projects. Usage of this is exemplified
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
