[
https://issues.apache.org/jira/browse/ROCKETMQ-106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944513#comment-15944513
]
ASF GitHub Bot commented on ROCKETMQ-106:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/66
@lizhanhui for your second point, we just disable the topic level flow
control by default will do the trick.
pullThresholdForTopic = Integer.MAX_VALUE;
max value will be considered as disable, so no need to introduce a
redundant config, which makes api harder to understand.
> Add flow control on topic level
> -------------------------------
>
> Key: ROCKETMQ-106
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-106
> Project: Apache RocketMQ
> Issue Type: Wish
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
>
> *Motivations*
> For current flow control, we can only control on queue level.
> Howerver, the numbers of queue allocated may be dynamic changed. For example,
> I might hope to control that at most 1000 messages can be pulled from broker
> to protect my client. And I have no idea how many queue I am allocated. Maybe
> I will have 5 queue and 5 instances so I set `pullThresholdForQueue`=1000,
> which works as expected when one is fine. But as long as any instances
> crashes, some instances may be allocated more than one queue, which will
> make messages pulled from broker exceed my expectations.
> A configuration of `pullThresholdForTopic` is propably most user hopes.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
