[jira] [Commented] (ROCKETMQ-166) onException callback may capture compressed message body

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15959196#comment-15959196
 ] 

ASF GitHub Bot commented on ROCKETMQ-166:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/89
  
    
    [![Coverage 
Status](https://coveralls.io/builds/10964577/badge)](https://coveralls.io/builds/10964577)
    
    Coverage increased (+0.04%) to 31.927% when pulling 
**638a692b9540f31768b76d43936a3ca277138ae1 on lizhanhui:ROCKETMQ-166** into 
**45a64fd6a8ab66a8b0eb30cbe2dffd59b19274f9 on apache:develop**.



> onException callback may capture compressed message body
> --------------------------------------------------------
>
>                 Key: ROCKETMQ-166
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-166
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-client
>    Affects Versions: 4.0.0-incubating, 4.1.0-incubating
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.1.0-incubating
>
>
> If message body size exceeds specified threshold, client would try to 
> compress the message body. 
> Here there are two issues: 1) current implementation changes message body 
> directly, which is not a good practice; 2) if asynchronous send method is 
> employed to deliver message, when onException is invoked, the callback may 
> capture the compressed message body before the finally block restores it.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)