[
https://issues.apache.org/jira/browse/ROCKETMQ-89?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15965913#comment-15965913
]
ASF GitHub Bot commented on ROCKETMQ-89:
----------------------------------------
Github user lizhanhui commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/55
> But I don't quite understand why it has to have so many levels -- why not
to remove rmqAddressServerDomain and let the user use only
rocketmq.namesrv.domain ... ?
Yes, I am also considering centralizing default values to an external
config-default.conf file and expose config.conf for user to override. This is
best conducted in a dedicated PR after discussion.
For this PR, let's fix the logical fault first.
> WS_DOMAIN_NAME, SUBGROUP default values overrides custom values passed by
> java options
> --------------------------------------------------------------------------------------
>
> Key: ROCKETMQ-89
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-89
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
> Priority: Minor
> Fix For: 4.1.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
