[
https://issues.apache.org/jira/browse/ROCKETMQ-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970618#comment-15970618
]
ASF GitHub Bot commented on ROCKETMQ-172:
-----------------------------------------
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111699928
--- Diff:
client/src/main/java/org/apache/rocketmq/client/impl/MQClientAPIImpl.java ---
@@ -577,12 +577,12 @@ public void operationComplete(ResponseFuture
responseFuture) {
}
} else {
if (!responseFuture.isSendRequestOK()) {
- pullCallback.onException(new
MQClientException("send request failed", responseFuture.getCause()));
+ pullCallback.onException(new
MQClientException("send request failed to " + addr + ".request: " + request,
responseFuture.getCause()));
--- End diff --
How about writing it this way?
`new MQClientException("send request [" + request+ "] failed to " + addr,
responseFuture.getCause())`
> log improvement for rocketmq client
> -----------------------------------
>
> Key: ROCKETMQ-172
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-172
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
>
> For some exception scenario, the log is not abundant enough to diagnose the
> problem.
> Some works should be done to improve the log messages
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
