[
https://issues.apache.org/jira/browse/ROCKETMQ-161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970695#comment-15970695
]
ASF GitHub Bot commented on ROCKETMQ-161:
-----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/87
@dongeforever Sorry, I don't think this modification is needed. A user will
modify this file anyway in order to match his/her system requirements.
Also, there are even more flags, and if you take this approach, you may
have to add more variables for each in future, which will make the script
tricky.
> Update runbroker.sh and runserver.sh to support user defined jvm memory flag
> ----------------------------------------------------------------------------
>
> Key: ROCKETMQ-161
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-161
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: dongeforever
> Assignee: dongeforever
>
> JVM mem flag is hard coded in runbroker.sh as follows:
> JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
> If one want to change such flag, he has to change the script, this is not
> friendly, especially in docker environment.
> Instead, it is able to use an environment variable to handle user defined
> flag, like:
> if [ -z $BROKER_MEM_OPS ]; then
> BROKER_MEM_OPS = "-Xms8g -Xmx8g -Xmn4g"
> fi
> JAVA_OPT="${JAVA_OPT} -server $BROKER_MEM_OPS"
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
