[
https://issues.apache.org/jira/browse/ROCKETMQ-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15970850#comment-15970850
]
ASF GitHub Bot commented on ROCKETMQ-172:
-----------------------------------------
Github user Jaskey commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/90#discussion_r111720177
--- Diff:
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingClient.java
---
@@ -321,6 +321,7 @@ public void updateNameServerAddressList(List<String>
addrs) {
if (update) {
Collections.shuffle(addrs);
+ log.info("name server address updated. NEW : {} , OLD:
{}",addrs,old);
--- End diff --
Perhaps we can post another PR for some logging format, currently I would
just retain the current way
> log improvement for rocketmq client
> -----------------------------------
>
> Key: ROCKETMQ-172
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-172
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Jaskey Lam
>
> For some exception scenario, the log is not abundant enough to diagnose the
> problem.
> Some works should be done to improve the log messages
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
