[
https://issues.apache.org/jira/browse/ROCKETMQ-191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15988126#comment-15988126
]
ASF GitHub Bot commented on ROCKETMQ-191:
-----------------------------------------
GitHub user lizhanhui opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/100
BugFix: ROCKETMQ-191
As we are setting socket options(sndbuf/recvbuf size) for the future
SocketChannel, we need to use childOption for ServerBootstrap class.
Semantics differences can be found [Netty
docs](http://netty.io/wiki/user-guide-for-4.x.html)
Actually, this is an easy-to-get-confused issue, [Spark had a similar bug
too](https://issues.apache.org/jira/browse/SPARK-3502)
[Vertx has similar settings that we can refer
to](https://github.com/eclipse/vert.x/blob/master/src/main/java/io/vertx/core/net/impl/NetServerBase.java)
See the `applyConnectionOptions` method.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lizhanhui/incubator-rocketmq ROCKETMQ-191
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/100.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #100
----
commit c80d40abecfe745ff7b17e297d8f04f969f54d8e
Author: Li Zhanhui <[email protected]>
Date: 2017-04-28T03:29:24Z
BugFix: ROCKETMQ-191
----
> Fix incorret socket option
> --------------------------
>
> Key: ROCKETMQ-191
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-191
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-remoting
> Affects Versions: 4.1.0-incubating
> Reporter: Zhanhui Li
> Assignee: Zhanhui Li
> Fix For: 4.1.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
