[
https://issues.apache.org/jira/browse/ROCKETMQ-114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15996439#comment-15996439
]
ASF GitHub Bot commented on ROCKETMQ-114:
-----------------------------------------
Github user shroman commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/80#discussion_r114733685
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/BrokerStartup.java ---
@@ -95,52 +141,65 @@ public static BrokerController
createBrokerController(String[] args) {
final BrokerConfig brokerConfig = new BrokerConfig();
final NettyServerConfig nettyServerConfig = new
NettyServerConfig();
final NettyClientConfig nettyClientConfig = new
NettyClientConfig();
- nettyServerConfig.setListenPort(10911);
+ nettyServerConfig.setListenPort(10911); // Set default broker
listen port
final MessageStoreConfig messageStoreConfig = new
MessageStoreConfig();
if (BrokerRole.SLAVE == messageStoreConfig.getBrokerRole()) {
+
+ // Use a conservative value for slave brokers so that
consumer groups won't frequently change targeting
+ // brokers when they are consuming messages at the
boundary between being probably resident in physical
+ // memory and swapped out.
int ratio =
messageStoreConfig.getAccessMessageInMemoryMaxRatio() - 10;
messageStoreConfig.setAccessMessageInMemoryMaxRatio(ratio);
}
- if (commandLine.hasOption('p')) {
+ // FIXME: log should not be null
--- End diff --
Creating a JIRA issue for this and having its number as a comment is a good
practice.
> Add javadoc to codebase
> -----------------------
>
> Key: ROCKETMQ-114
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-114
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Zhanhui Li
> Assignee: vongosling
> Fix For: 4.1.0-incubating
>
>
> Quality documentation is critically important to develop and maintain a
> project. The better the documentation is, the
> easier it will be for other participants to understand and respond properly.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
