[ 
https://issues.apache.org/jira/browse/ROCKETMQ-219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040411#comment-16040411
 ] 

ASF GitHub Bot commented on ROCKETMQ-219:
-----------------------------------------

Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/112#discussion_r120535326
  
    --- Diff: 
example/src/main/java/org/apache/rocketmq/example/batch/SplitBatchProducer.java 
---
    @@ -0,0 +1,97 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + *  Unless required by applicable law or agreed to in writing, software
    + *  distributed under the License is distributed on an "AS IS" BASIS,
    + *  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or 
implied.
    + *  See the License for the specific language governing permissions and
    + *  limitations under the License.
    + */
    +
    +package org.apache.rocketmq.example.batch;
    +
    +import java.util.ArrayList;
    +import java.util.Iterator;
    +import java.util.List;
    +import java.util.Map;
    +import org.apache.rocketmq.client.producer.DefaultMQProducer;
    +import org.apache.rocketmq.common.message.Message;
    +
    +public class SplitBatchProducer {
    --- End diff --
    
    What about adding comments to this sample class to explain what it is going 
to demonstrate, since this example seem to be a little complicated.


> Add Batch Example
> -----------------
>
>                 Key: ROCKETMQ-219
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-219
>             Project: Apache RocketMQ
>          Issue Type: Wish
>            Reporter: dongeforever
>            Assignee: dongeforever
>             Fix For: 4.1.0-incubating
>
>
> Add batch example



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to