[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16040480#comment-16040480
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:
----------------------------------------

Github user Jaskey commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/111#discussion_r120276124
  
    --- Diff: 
remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingServer.java
 ---
    @@ -128,6 +131,19 @@ public Thread newThread(Runnable r) {
                     }
                 });
             }
    +
    --- End diff --
    
    How about extract these code to a method, `buildSSLContext` in 
`NettyRemoteAbstact` for both client and server


> Transportation Layer Security
> -----------------------------
>
>                 Key: ROCKETMQ-28
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-remoting
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to