[
https://issues.apache.org/jira/browse/ROCKETMQ-214?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16055897#comment-16055897
]
ASF GitHub Bot commented on ROCKETMQ-214:
-----------------------------------------
GitHub user lqjack opened a pull request:
https://github.com/apache/incubator-rocketmq/pull/122
ROCKETMQ-214
wrapper the AllocateMessageQueueStrategy with ThreadLocal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lqjack/incubator-rocketmq ROCKETMQ-214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-rocketmq/pull/122.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #122
----
commit 9b8ef96bcaede4a20f2a0e63ca9a5727e17b6d99
Author: lqjaclee <[email protected]>
Date: 2017-06-20T15:04:13Z
ROCKETMQ-214: wrapper the AllocateMessageQueueStrategy with ThreadLocal
----
> Improvement to help client to switch balance strategy smoothly
> --------------------------------------------------------------
>
> Key: ROCKETMQ-214
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-214
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client
> Reporter: Jaskey Lam
> Assignee: Xiaorui Wang
>
> In current implementations, rocketmq consumer will allocate message queue in
> client itself by fetching all clientid and all mq.
> While when user hopes to switch balance strategy, some problem will be
> suffered in the intermediate state before all client instance have been
> change to the same new strategy.
> Say there are there clients with Strategy `AllocateMessageQueueAveragely`,
> when users needs to use their own `AllocateMessageQueueStrategy`, and they
> upgrade the client1 , and some mq will be missing to allocate or some mq
> allocate to multiple client instances, which will result in message
> duplication or message accumulation that fail to be consumed
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
