[ 
https://issues.apache.org/jira/browse/ROCKETMQ-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066259#comment-16066259
 ] 

ASF GitHub Bot commented on ROCKETMQ-28:
----------------------------------------

Github user lizhanhui commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/118#discussion_r124500517
  
    --- Diff: client/src/main/java/org/apache/rocketmq/client/ClientConfig.java 
---
    @@ -173,12 +177,20 @@ public void setVipChannelEnabled(final boolean 
vipChannelEnabled) {
             this.vipChannelEnabled = vipChannelEnabled;
         }
     
    +    public boolean isUseTLS() {
    +        return useTLS;
    +    }
    +
    +    public void setUseTLS(boolean useTLS) {
    +        this.useTLS = useTLS;
    +    }
    +
         @Override
         public String toString() {
             return "ClientConfig [namesrvAddr=" + namesrvAddr + ", clientIP=" 
+ clientIP + ", instanceName=" + instanceName
                 + ", clientCallbackExecutorThreads=" + 
clientCallbackExecutorThreads + ", pollNameServerInterval=" + 
pollNameServerInterval
                 + ", heartbeatBrokerInterval=" + heartbeatBrokerInterval + ", 
persistConsumerOffsetInterval="
                 + persistConsumerOffsetInterval + ", unitMode=" + unitMode + 
", unitName=" + unitName + ", vipChannelEnabled="
    -            + vipChannelEnabled + "]";
    +            + vipChannelEnabled + ", useTLS=" + useTLS + "]";
    --- End diff --
    
    I do not get your point. You mean change "+" to a chain of append() method 
invocations?


> Transportation Layer Security
> -----------------------------
>
>                 Key: ROCKETMQ-28
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-28
>             Project: Apache RocketMQ
>          Issue Type: New Feature
>          Components: rocketmq-remoting
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>             Fix For: 4.2.0-incubating
>
>
> RocketMQ delivers data in clear text for now, which requires internal network 
> environment. As use scenarios expand, end-to-end security is in bad need. 
> This issue is to introduce features making RocketMQ security for various use 
> cases and sacrificing as few as possible.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to