[
https://issues.apache.org/jira/browse/ROCKETMQ-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16066466#comment-16066466
]
ASF GitHub Bot commented on ROCKETMQ-234:
-----------------------------------------
Github user evthoriz commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/128
@Jaskey From the aspect of client, every batch request would cause printing
2 warning logs. But the further influence is it may damage the performance in
high throughput scenario where batch interface would more likely be used,
because it wasted netty's IO thread time doing meaningless encoding, decoding
and printing logs things.
> Bugfix in batch scenario
> ------------------------
>
> Key: ROCKETMQ-234
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-234
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-broker
> Affects Versions: 4.1.0-incubating, 4.2.0-incubating
> Reporter: Yu Kaiyuan
> Assignee: yukon
>
> Bug in handle batch response. Broker will write response twice to client in
> batch scenario.
> Details below:
> {code:java}
> private RemotingCommand sendBatchMessage(...)
> {
> // ignore irrelevant logic...
> // here in handlePutMessageResult function, reponse will be written back
> through ctx once
> handlePutMessageResult(putMessageResult, response, request,
> messageExtBatch, responseHeader, sendMessageContext, ctx, queueIdInt);
> // the response returned here will be written back again if response is
> not null
> return response;
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
