[
https://issues.apache.org/jira/browse/ROCKETMQ-6?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073396#comment-16073396
]
ASF GitHub Bot commented on ROCKETMQ-6:
---------------------------------------
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/3#discussion_r93905062
--- Diff:
rocketmq-remoting/src/main/java/com/alibaba/rocketmq/remoting/common/ServiceThread.java
---
@@ -86,7 +86,7 @@ public void stop() {
public void stop(final boolean interrupt) {
this.stopped = true;
- STLOG.info("stop thread " + this.getServiceName() + " interrupt "
+ interrupt);
+ log.info("stop thread " + this.getServiceName() + " interrupt " +
interrupt);
--- End diff --
the same
> Use logger for exceptions instead of e.printStackTrace()
> --------------------------------------------------------
>
> Key: ROCKETMQ-6
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-6
> Project: Apache RocketMQ
> Issue Type: Improvement
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Fix For: 4.2.0-incubating
>
>
> Replace {{e.printStackTrace()}} with {{log.error(...)}} in all core modules,
> except tests, tools and examples.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
