[
https://issues.apache.org/jira/browse/ROCKETMQ-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16081549#comment-16081549
]
ASF GitHub Bot commented on ROCKETMQ-243:
-----------------------------------------
Github user Jaskey commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/130
@shroman Sorry I misunderstand this method that I though it returns the
master address, since it is prefered to return the master address then slave,
renaming seems to be not necessary while comment should be modified since it is
only randomly pick while master is not found, thus only slave will be randomly
pick.
> BrokerData#selectBrokerAddr() picks the 1st element in the list of addresses
> ----------------------------------------------------------------------------
>
> Key: ROCKETMQ-243
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-243
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-commons
> Affects Versions: 4.1.0-incubating
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
> Priority: Minor
>
> I wonder if this can cause broker contention. Therefore I propose to pick the
> address at least in a random manner.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
