[
https://issues.apache.org/jira/browse/ROCKETMQ-249?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125152#comment-16125152
]
ASF GitHub Bot commented on ROCKETMQ-249:
-----------------------------------------
Github user solosky commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/133#discussion_r132864458
--- Diff: common/src/main/java/org/apache/rocketmq/common/UtilAll.java ---
@@ -184,15 +184,27 @@ public static String timeMillisToHumanString3(final
long t) {
cal.get(Calendar.SECOND));
}
+ /**
+ * Estimates the disk usage percentage by the specified path.
+ *
+ * @param path Path.
+ * @return Disk usage percentage by path.
+ */
public static double getDiskPartitionSpaceUsedPercent(final String
path) {
- if (null == path || path.isEmpty())
+ if (null == path || path.isEmpty()) {
--- End diff --
we should use StringUtils.isBlank(..) instead as a basic practice.
> Attempt to clear disk even if disk store path is found
> ------------------------------------------------------
>
> Key: ROCKETMQ-249
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-249
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> If disk usage estimates fail because the disk store path is not found
> (doesn't exist), message store falsely decides the disk is full and tries to
> delete.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
