[
https://issues.apache.org/jira/browse/ROCKETMQ-266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16128383#comment-16128383
]
ASF GitHub Bot commented on ROCKETMQ-266:
-----------------------------------------
Github user mark800 commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/147#discussion_r133365826
--- Diff:
client/src/test/java/org/apache/rocketmq/client/impl/consumer/DefaultMQPushConsumerImplTest.java
---
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.client.impl.consumer;
+
+import java.util.List;
+import org.apache.rocketmq.client.consumer.DefaultMQPushConsumer;
+import
org.apache.rocketmq.client.consumer.listener.ConsumeConcurrentlyContext;
+import
org.apache.rocketmq.client.consumer.listener.ConsumeConcurrentlyStatus;
+import
org.apache.rocketmq.client.consumer.listener.MessageListenerConcurrently;
+import org.apache.rocketmq.client.exception.MQClientException;
+import org.apache.rocketmq.common.message.MessageExt;
+import org.junit.Test;
+
+public class DefaultMQPushConsumerImplTest {
+ @Test(expected = MQClientException.class)
+ public void checkConfigTest() throws Exception {
+ DefaultMQPushConsumer consumer = new
DefaultMQPushConsumer("test_consumer_group");
+
+ consumer.setConsumeThreadMax(10);
--- End diff --
The test case’s purpose is: If the consumeThreadMax is less than
consumeThreadMin, we should get a proper exception message, the one line is
enough.
The DefaultMQPushConsumerImpl.java class needs a lot more test case, a lot
of condition should be checked, but that’s not this PR’s purpose.
> Can’t start consumer with a small “consumerThreadMax” number
> ------------------------------------------------------------
>
> Key: ROCKETMQ-266
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-266
> Project: Apache RocketMQ
> Issue Type: Bug
> Components: rocketmq-client
> Affects Versions: 4.1.0-incubating
> Reporter: Mark Yang
> Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
