[jira] [Commented] (ROCKETMQ-284) ExpressionMessageFilter will pass some message

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-284?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16145120#comment-16145120
 ] 

ASF GitHub Bot commented on ROCKETMQ-284:
-----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/160
  
    
    [![Coverage 
Status](https://coveralls.io/builds/13031998/badge)](https://coveralls.io/builds/13031998)
    
    Coverage increased (+0.1%) to 38.755% when pulling 
**3f78c4e2160f6bb9d8a08934e391b3c81db7b72e on vsair:ROCKETMQ-284** into 
**4c5e58b46acaf4541fbd741b97593618f027be2d on apache:develop**.



> ExpressionMessageFilter will pass some message
> ----------------------------------------------
>
>                 Key: ROCKETMQ-284
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-284
>             Project: Apache RocketMQ
>          Issue Type: Bug
>          Components: rocketmq-broker
>    Affects Versions: 4.1.0-incubating
>            Reporter: Eric Liu
>            Assignee: Eric Liu
>             Fix For: 4.2.0-incubating
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> ExpressionMessageFilter will pass some message with tag's hash code less than 
> 0.
> This is not correct. After sql filter feature added, the tag's hash code in 
> consume queue may be replaced by the address of consume queue ext. And, 
> differences between them are:
> 1. Tag's hash code is an integer, values is between Integer.MIN and 
> Integer.MAX.
> 2. Address of consume queue ext is a long, values is between Long.MIN and 
> Integer.MIN - 1.
> So, actually,  they are not conflict.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)