[
https://issues.apache.org/jira/browse/ROCKETMQ-271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172691#comment-16172691
]
ASF GitHub Bot commented on ROCKETMQ-271:
-----------------------------------------
Github user dongeforever commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/156#discussion_r139869169
--- Diff:
broker/src/main/java/org/apache/rocketmq/broker/mqtrace/TrackerTimeSendMessageHook.java
---
@@ -0,0 +1,62 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.rocketmq.broker.mqtrace;
+
+import java.util.Map;
+import org.apache.rocketmq.broker.ServerTracerTimeUtil;
+import org.apache.rocketmq.common.message.MessageConst;
+import org.apache.rocketmq.common.message.MessageDecoder;
+
+public class TrackerTimeSendMessageHook implements SendMessageHook {
+
+ @Override
+ public String hookName() {
+ return "TrackerTimeSendMessageHook";
+ }
+
+ @Override
+ public void sendMessageBefore(SendMessageContext context) {
+ // brokerController.getBrokerConfig().isEnableTracerTime()
+ String props = context.getMsgProps();
+ if (props != null && props.length() > 1) {
+ Map<String, String> properties =
MessageDecoder.string2messageProperties(props);
+ String messageTracerTimeId =
properties.get(MessageConst.PROPERTY_UNIQ_CLIENT_MESSAGE_ID_KEYIDX);
+ if (properties.containsKey(MessageConst.MESSAGE_CREATE_TIME)) {
+
ServerTracerTimeUtil.addMessageCreateTime(messageTracerTimeId,
properties.get(MessageConst.MESSAGE_CREATE_TIME));
+
ServerTracerTimeUtil.addMessageSendTime(messageTracerTimeId,
properties.get(MessageConst.MESSAGE_SEND_TIME));
+
ServerTracerTimeUtil.addMessageArriveBrokerTime(messageTracerTimeId,
System.currentTimeMillis());
+
ServerTracerTimeUtil.addMessageBeginSaveTime(messageTracerTimeId,
System.currentTimeMillis());
+ }
+ }
+
+ }
+
+ @Override
+ public void sendMessageAfter(SendMessageContext context) {
+ String props = context.getMsgProps();
+ if (props != null && props.length() > 1) {
+ Map<String, String> properties =
MessageDecoder.string2messageProperties(props);
+ if (properties.containsKey(MessageConst.MESSAGE_CREATE_TIME)) {
+ String messageTracerTimeId =
properties.get(MessageConst.PROPERTY_UNIQ_CLIENT_MESSAGE_ID_KEYIDX);
+
ServerTracerTimeUtil.addMessageSaveEndTime(messageTracerTimeId,
System.currentTimeMillis());
+
ServerTracerTimeUtil.addBrokerSendAckTime(messageTracerTimeId,
System.currentTimeMillis());
+
ServerTracerTimeUtil.addBrokerSendAckTime(messageTracerTimeId,
System.currentTimeMillis());
--- End diff --
here two lines are same.
May you want to addReceiveSendAckTime?
> add diagnosis tools
> -------------------
>
> Key: ROCKETMQ-271
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-271
> Project: Apache RocketMQ
> Issue Type: New Feature
> Components: rocketmq-broker, rocketmq-client, rocketmq-commons,
> rocketmq-remoting
> Reporter: yubaofu
> Assignee: yukon
> Priority: Minor
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> when prodcurer send message timeout,how to find the root cause,it's difficult.
> so add the new diagnosis tools that record message lifetime ,eg message
> create time,prodcurer send message to broker time,broker recive message
> time,and send response to client time.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
