[
https://issues.apache.org/jira/browse/ROCKETMQ-278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16172707#comment-16172707
]
ASF GitHub Bot commented on ROCKETMQ-278:
-----------------------------------------
Github user vongosling commented on a diff in the pull request:
https://github.com/apache/incubator-rocketmq/pull/152#discussion_r139871898
--- Diff:
tools/src/main/java/org/apache/rocketmq/tools/command/topic/TopicListSubCommand.java
---
@@ -65,7 +65,7 @@ public void execute(final CommandLine commandLine, final
Options options,
try {
defaultMQAdminExt.start();
if (commandLine.hasOption('c')) {
- ClusterInfo clusterInfo =
defaultMQAdminExt.examineBrokerClusterInfo();
+ ClusterInfo clusterInfo =
defaultMQAdminExt.examineBrokerClusterInfo(null);
--- End diff --
null as parameter is not a good practice
> Add specified cluster for cluster info cmd
> ------------------------------------------
>
> Key: ROCKETMQ-278
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-278
> Project: Apache RocketMQ
> Issue Type: Improvement
> Components: rocketmq-client, rocketmq-namesrv, rocketmq-tools
> Affects Versions: 4.1.0-incubating
> Reporter: lindzh
> Assignee: Xiaorui Wang
> Fix For: 4.2.0-incubating
>
>
> When using mqadmin command clusterlist,it always display all cluster,i want
> to display specified cluster.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
