carlosrovira commented on issue #127: ClassReference doesn't work in themes URL: https://github.com/apache/royale-asjs/issues/127#issuecomment-373365576 That case will fail since there are visuals that are missed. If the case is valid is what we should decide We can think about this how we want to define it: 1) Is the theme is incomplete?, so is up to you to complete with the needed classes to be valid. 2) Should we consider a theme can't miss any of its building pieces? (code, styles, images, assets,... We can duplicate classes in the jewel library with visuals that most of the time will never be used carrying all the weight, but in that case shall we put in the library the rest of assets (css, images,...) to avoid fail at runtime? (fails can be of building since there's something missing like code, or at runtime, since there's some image or css that is not there and makes the visuals shows distorted) IMO, it's a matter of separation of concerns. Conceptually visuals should be in theme and logic should be in libs, that's how I always structure projects in Flex even in final apps and modules. But I could be wrong.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
