greg-dove opened a new issue #93: Change to XML.children() is non-conforming/breaks tests URL: https://github.com/apache/royale-compiler/issues/93 @Harbs the change in https://github.com/apache/royale-asjs/commit/64eb73564aa9f3186477416cee575ceed1625cf9 causes wrong results. XML.children() is not just elements, that includes text and comments etc... The change breaks some of the tests in the manualtests project which tests XML across swf and javascript. (I will port these tests to RoyaleUnit at some point in the near future, so it will be more obvious if there is a breaking change in the future) You can also check this quickly by pasting the following in Adobe Animate: ``` XML.ignoreWhitespace = true; XML.ignoreComments = false; var xml:XML = new XML('<root><!-- my test comment --></root>'); trace("-->>"+xml.children().toXMLString()+"<<--") // -->><!-- my test comment --><<-- trace(xml.children().length()) //1 ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
