greg-dove commented on issue #93: Change to XML.children() is 
non-conforming/breaks tests
URL: https://github.com/apache/royale-compiler/issues/93#issuecomment-520118499
 
 
   @Harbs I have ported the XML tests across to RoyaleUnit.
   The failing tests are marked with [Ignore] to avoid breaking the build.
   here: 
https://github.com/apache/royale-asjs/blob/be1f5a74cabc1fec32bc9d7c1fd6a3d7dcc382e9/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as#L162
   
here:https://github.com/apache/royale-asjs/blob/be1f5a74cabc1fec32bc9d7c1fd6a3d7dcc382e9/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as#L577
   here: 
https://github.com/apache/royale-asjs/blob/be1f5a74cabc1fec32bc9d7c1fd6a3d7dcc382e9/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as#L700
   and here: 
https://github.com/apache/royale-asjs/blob/be1f5a74cabc1fec32bc9d7c1fd6a3d7dcc382e9/frameworks/projects/XML/src/test/royale/flexUnitTests/xml/XMLTesterGeneralTest.as#L726
   
   I think these are all likely related to the XML.children() errors. I plan to 
restore these tests to passing on on my Monday. I will also add more tests to 
cover variations in ignoreWhiteSpace, ignoreProcessingInstructions, 
ignoreComments etc as they relate to return values for children() method. 
Hopefully by doing so, I can address the original issue you were seeing, which 
I'm guessing might have been related to something like that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to