Harbs commented on issue #641: Fix PAYG violations and code debt URL: https://github.com/apache/royale-asjs/issues/641#issuecomment-569542583 Good luck with the reflection data. FWIW, I see 49 instances of `methods:function(){return{` in the code (which is a good indication of reflection data which was not optimized away). There are a number of different cases where we're specifying @export: 1. `goog.exportSymbol` on classes. 2. `public static function`s 3. `public static var`s 4. `public static const`s 5. For `public static` getters, we're using brackets to prevent renaming. (IIRC) 6. `public function`s 7. `public var`s 8. public getters and setters I think we should reexamine all of these and document the reason for each of these, so we can make intelligent decisions on when exactly it's necessary. Additionally, it might be helpful to try and figure out if there's some way to enable dead-code removal of some public members to enable PAYG on some pieces while making it easier to design and use components. What's unclear to me at the moment is specifically item 2 and 6. Why is it necessary to `@export` functions (both static and otherwise). Additionally (possibly related), I don't understand why it's necessary to include methods in reflection data.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
