[GitHub] [royale-asjs] Harbs opened a new issue #643: Crux broken in minified app

[GitBox]

Harbs opened a new issue #643: Crux broken in minified app
URL: https://github.com/apache/royale-asjs/issues/643
 
 
   I traced the problem to here:
   In CruxManager, there's the following code:
   `            public static var wiredViews:Map = new Map();`
   
   That gets compiled to:
   
   ````
   org.apache.royale.crux.CruxManager.get__wiredViews = function() {
     var value = new Map();
     Object.defineProperty(org.apache.royale.crux.CruxManager, 'wiredViews', { 
value: value, writable: true });
     return value;
   };
   org.apache.royale.crux.CruxManager.set__wiredViews = function(value) {
     Object.defineProperty(org.apache.royale.crux.CruxManager, 'wiredViews', { 
value: value, writable: true });
   };
   Object.defineProperties(org.apache.royale.crux.CruxManager, /** @lends 
{org.apache.royale.crux.CruxManager} */ {
   /**
    * @export
    * @type {Map}
    */
   wiredViews: {
     get: org.apache.royale.crux.CruxManager.get__wiredViews,
     set: org.apache.royale.crux.CruxManager.set__wiredViews,
     configurable: true}});
   ````
   In CruxManager.setup, there is the following code:
   ````
     if (org.apache.royale.crux.CruxManager.wiredViews.get(view) != null)
       return;
   ````
   When minified, `org.apache.royale.crux.CruxManager.wiredViews` gets minified 
to a global variable (in my case `xn`) `xn` is undefined because the Map was 
defined in the getter which the global `xn` is not accessing.
   
   I'm not sure when this change to static vars was done, but this seems wrong.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services