Harbs commented on issue #641: Fix PAYG violations and code debt URL: https://github.com/apache/royale-asjs/issues/641#issuecomment-573836029 It looks to me that there's a lot of code in `SimpleCSSValuesImpl` that's needed for the simple SWF implementation, but not required for JS apps. Here's items which look to me that they're not really needed on the JS side: 1. Color parsing. (i.e. `CSSUtils.toColor` and `CSSUtils.toColorWithAlpha`) Anything which is being applied to CSS can be blindly applied as-is and the browser will either apply a valid color or silently fail. 2. `BorderStyles`. Except for MX (not sure if it's needed there or not), this is only used for SWF rendering. 3. Measurement function: It seems to me like function such as `getBorderAndPaddingMetrics`, `getMargins` etc. can be utility function that would only be pulled in if there are layout beads which use them. `getBorderAndPaddingMetrics` in particular seems like a good candidate considering it's barely used. 4. `getBorderPaddingAndMargins` I don't see where that one is used at all.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
