greg-dove commented on issue #116: SWC builds appear to add all files to 
'definition stores', which includes (in some cases) files with no actual 
definitions.
URL: https://github.com/apache/royale-compiler/issues/116#issuecomment-581094457
 
 
   @aharui 
   It is probably describing something similar, but this issue is additionally 
describing what I think is an invalid internal state for the compiler, that can 
result from that.
   The outcome is nothing bad (beyond the strange warnings being displayed) in 
this case, so I don't think this is a priority. But something does not seem 
right to me here, and may not make sense longer term...
   
   The warning is essentially saying that something in the airglobal.swc can't 
find one of its dependencies also defined in the same swc. The reason is 
because an 'empty' project-local file that was not intended to be and will 
never be included in the swf version of the XML swc build is hiding it.
   
   The 'XML' lib classes only have a 'COMPILE::JS' definition and there is no 
definition for COMPILE::SWF content - because they are obviously already 
defined in the airglobal/playerglobal as native classes.
   The behavior inside the compiler appears to create an invalid internal view 
of the loaded definitions for swf compilation of this lib, where the 'empty' 
local source files override/shadow the original native definitions with an 
invalid 'DefinitionPromise', which seems wrong IMO.... especially as they are 
both a) empty for swf and b) not specified as being included in the swc.
   
   I'm not giving this more attention at the moment apart from seeking to 
understand it... and documenting that here. If you really feel like this is not 
an issue for some reason, feel free to close it with a quick explanation why.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to