greg-dove commented on issue #144: Works on given test case. Hope I didn't break anything. URL: https://github.com/apache/royale-compiler/pull/144#issuecomment-609485205 I just saw this review request yishay, I had already replied to the commit email with a couple of quick suggestions. I will try to look at this in more detail tonight my time. Here's what I added via email: -You might find a place in the code where there is something already that has 'needClosure' logic, but the logic that sets it to true does not yet include the specific case you are dealing with. -Take a look at emitClosureStart and emitClosureEnd I think those will help out. (The second one is likely not needed if the first one is a solution, but these are just clues to help you better understand the compiler code, not any recommendation about the way to do what you are specifically working to fix - I have not looked into it yet)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
