yishayw commented on a change in pull request #869:
URL: https://github.com/apache/royale-asjs/pull/869#discussion_r441651883



##########
File path: 
frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/combobox/ComboBoxItemByField.as
##########
@@ -0,0 +1,71 @@
+package com.iest.winplusweb.beads
+{
+  import org.apache.royale.core.IBead;
+  import org.apache.royale.jewel.ComboBox;
+  import org.apache.royale.core.IStrand;
+  import org.apache.royale.collections.CollectionUtils;
+  import org.apache.royale.collections.ArrayList;
+  import org.apache.royale.events.Event;
+
+  public class ComboBoxItemByField implements IBead{
+
+      protected var comboBox:ComboBox;
+
+
+      public function ComboBoxItemByField()
+               {
+               }
+
+        public function set strand(value:IStrand):void
+               {
+                       comboBox = value as ComboBox;

Review comment:
       Have you considered casting this to an interface so it can work on 
strands other than jewel ComboBox? It could be better to place this in Basic so 
other component sets can use this.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to