yishayw commented on pull request #870: URL: https://github.com/apache/royale-asjs/pull/870#issuecomment-646219737
Looks good to me. I’ll wait for other committers to have a look and if no changes are made I’ll merge tomorrow. Thanks a lot Raul. From: raudjcholo<mailto:[email protected]> Sent: Thursday, June 18, 2020 8:47 PM To: apache/royale-asjs<mailto:[email protected]> Cc: Subscribed<mailto:[email protected]> Subject: [apache/royale-asjs] Change ComboBoxItemByField for a Basic Bead (#870) I have changed ComboBoxItemByField so that it can be used b more components. You can view, comment on, or merge this pull request online at: https://github.com/apache/royale-asjs/pull/870 Commit Summary * Change ComboBoxItemByField for a Basic Bead so that it can be used by more components File Changes * M frameworks/projects/Basic/src/main/resources/basic-manifest.xml<https://github.com/apache/royale-asjs/pull/870/files#diff-3dfe518a6351a28146f92cca55dc0729> (2) * R frameworks/projects/Basic/src/main/royale/org/apache/royale/html/beads/CollectionSelectedItemByField.as<https://github.com/apache/royale-asjs/pull/870/files#diff-3246c06af8d465504030ae25c13b4379> (53) * M frameworks/projects/Jewel/src/main/resources/jewel-manifest.xml<https://github.com/apache/royale-asjs/pull/870/files#diff-d8bc3987efbc867eaa2ff368e35049a2> (1) Patch Links: * https://github.com/apache/royale-asjs/pull/870.patch * https://github.com/apache/royale-asjs/pull/870.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub<https://github.com/apache/royale-asjs/pull/870>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAQBE7NLAMOR2DXDOMKZPNDRXJHMDANCNFSM4OCAGUVQ>. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
