mjesteve commented on pull request #881: URL: https://github.com/apache/royale-asjs/pull/881#issuecomment-653142152
Created IImageButton interface (copy of IImage), modified Basic and Jewel ImageButton controls to implement it. Corrections indicated in # 880: - I still have doubts regarding the COMPILE :: JS directives. In IImage the get imageElement function is defined for JS only, shouldn't you keep COMPILE :: JS in every function where it appears? I have left the directive in private function beadsAddedHandler because in all the places where I have seen it implemented it is like this, but I don't know if it will be correct. I have compiled my fork and TDJ and it doesn't give me errors but I don't know if it will be correct. - (Uncorrected listener to addBead. Pending response in # 880) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
