carlosrovira commented on a change in pull request #908: URL: https://github.com/apache/royale-asjs/pull/908#discussion_r486240797
########## File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datagrid/DataGridSortBead.as ########## @@ -0,0 +1,89 @@ +//////////////////////////////////////////////////////////////////////////////// +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// +//////////////////////////////////////////////////////////////////////////////// + +package org.apache.royale.jewel.beads.controls.datagrid +{ + import org.apache.royale.core.IBead; + import org.apache.royale.core.IStrand; + import org.apache.royale.jewel.beads.views.DataGridView; + import org.apache.royale.events.MouseEvent; + import org.apache.royale.jewel.supportClasses.datagrid.DataGridButtonBar; + import org.apache.royale.collections.Sort; + import org.apache.royale.collections.SortField; + import org.apache.royale.collections.IArrayListView; + import org.apache.royale.jewel.supportClasses.datagrid.DataGridColumn; + + public class DataGridSortBead implements IBead + { + public function DataGridSortBead() + { + super(); + } + + private var dg:DataGrid; + + private var descending:Boolean; + + /** + * @copy org.apache.royale.core.IBead#strand + * + * @langversion 3.0 + * @playerversion Flash 10.2 + * @playerversion AIR 2.6 + * @productversion Royale 0.0 + */ + public function set strand(value:IStrand):void + { + dg = value as DataGrid; + (dg.view as DataGridView).header.addEventListener(MouseEvent.CLICK, mouseClickHandler, false); + } + + /** + * @private + */ + private function mouseClickHandler(event:MouseEvent):void + { + var dgView:DataGridView = dg.view as DataGridView; + var buttonBar:DataGridButtonBar = (dgView.header as DataGridButtonBar); + // probably down on one button and up on another button + // so the ButtonBar won't change selection + if (event.target == buttonBar) return; + var column:DataGridColumn = event.target.data as DataGridColumn; + var collection:IArrayListView = dg.dataProvider as IArrayListView; + if (collection && collection.length) + { + if (collection.sort && collection.sort.fields[0].name == column.dataField) + descending = !descending; + + var sort:Sort = new Sort(); + var sortField:SortField = new SortField(column.dataField, false, descending); + + sort.fields = [ sortField ]; + collection.sort = sort; + + (dgView.header as DataGridButtonBar).model.dispatchEvent(new Event("dataProviderChanged")); + + // force redraw of column headers + collection.refresh(); + dg.dataProvider = null; + dg.dataProvider = collection; Review comment: Maybe the refresh thing I pointed beore is what cause these 2 lines? normally refreshing and then signal a "dataProviderChanged" will run the code that removes the dataprovider and recreates all... (I could be wrong and some bug and/or changes could be in the underlying code ########## File path: frameworks/projects/Jewel/src/main/royale/org/apache/royale/jewel/beads/controls/datagrid/DataGridSortBead.as ########## @@ -0,0 +1,89 @@ +//////////////////////////////////////////////////////////////////////////////// +// +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +// +//////////////////////////////////////////////////////////////////////////////// + +package org.apache.royale.jewel.beads.controls.datagrid +{ + import org.apache.royale.core.IBead; + import org.apache.royale.core.IStrand; + import org.apache.royale.jewel.beads.views.DataGridView; + import org.apache.royale.events.MouseEvent; + import org.apache.royale.jewel.supportClasses.datagrid.DataGridButtonBar; + import org.apache.royale.collections.Sort; + import org.apache.royale.collections.SortField; + import org.apache.royale.collections.IArrayListView; + import org.apache.royale.jewel.supportClasses.datagrid.DataGridColumn; + + public class DataGridSortBead implements IBead + { + public function DataGridSortBead() + { + super(); + } + + private var dg:DataGrid; + + private var descending:Boolean; + + /** + * @copy org.apache.royale.core.IBead#strand + * + * @langversion 3.0 + * @playerversion Flash 10.2 + * @playerversion AIR 2.6 + * @productversion Royale 0.0 + */ + public function set strand(value:IStrand):void + { + dg = value as DataGrid; + (dg.view as DataGridView).header.addEventListener(MouseEvent.CLICK, mouseClickHandler, false); + } + + /** + * @private + */ + private function mouseClickHandler(event:MouseEvent):void + { + var dgView:DataGridView = dg.view as DataGridView; + var buttonBar:DataGridButtonBar = (dgView.header as DataGridButtonBar); + // probably down on one button and up on another button + // so the ButtonBar won't change selection + if (event.target == buttonBar) return; + var column:DataGridColumn = event.target.data as DataGridColumn; + var collection:IArrayListView = dg.dataProvider as IArrayListView; + if (collection && collection.length) + { + if (collection.sort && collection.sort.fields[0].name == column.dataField) + descending = !descending; + + var sort:Sort = new Sort(); + var sortField:SortField = new SortField(column.dataField, false, descending); + + sort.fields = [ sortField ]; + collection.sort = sort; + + (dgView.header as DataGridButtonBar).model.dispatchEvent(new Event("dataProviderChanged")); + + // force redraw of column headers + collection.refresh(); Review comment: In MX version we first "refresh" and the then send "dataProviderChanged", that not worked for you? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
