greg-dove commented on pull request #969: URL: https://github.com/apache/royale-asjs/pull/969#issuecomment-736215766
I have some WIP on an alternate implementation of this. I had started, but did not finish. The approach I took was to subclass XML (in as3 this is strictly not possible, but we can in js). If the notification support was requested, it swapped the prototype (again very js-ish) of the current XML instance to use overridden methods that support the notifications - if setNotification is subsequently set to null it swaps back to the lighter base class instance. I did not think (or know) about these bubbling. Your approach sounds comprehensive. I've encountered the same issues with non-iterable WeakMap/ Map (forEach needed by IE11) etc, so I know the decision path you went through there! I will come back and attach my WIP here just in case here you want to take a look at it - I'd be happy to look through your code, but I can't spend time on this until this coming weekend I'm afraid. Hopefully someone else can. I also wrote a bunch of unit tests for what I was working on - I will drop that here also - either later today or before I start work tomorrow morning local time ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
