cottage14 commented on pull request #992: URL: https://github.com/apache/royale-asjs/pull/992#issuecomment-741971702
While we have a growing list of pages in the help docs that detail the features of Jewel components and how to use them, we have nothing yet for Spark components. I can create a folder for such pages, but will need help populating the pages, if people feel this would be useful. I have created the folder and a page for SkinnableDataContainer [1], and perhaps @estanglerbm could take a stab at populating it. If you or someone can dump in the technical information, I can help with pulling the text together so it is useful. Andrew 1. https://github.com/apache/royale-docs/blob/master/component-sets/spark/skinnable-data-container On Wed, Dec 9, 2020 at 1:31 AM estanglerbm <[email protected]> wrote: > > - > > Implemented Spark SkinnableDataContainer, which is basically a > combination of DataGroup, List, and SkinnableContainer. > - > > Should use with DataGroup fix in #966 > <https://github.com/apache/royale-asjs/pull/966> (not included in this > pull request). > - > > Reconfigured CSS of DataGroup to implement more proper behavior. For > example, when DataGroup.itemRender = null, it can by default render VGroup > and such. It can also take different layouts. The old CSS for DataGroup, > which was List-oriented, has been copied to VirtualVDataGroup (and List > adjusted). Adjusted NonVirtualHDataGroup (used by TabBar) and commented out > NonVirtualVDataGroup (not used). > - > > Added SelfItemRendererInitializer (+ SelfItemRenderer) to render > UIComponent objects, such as VGroup and everything else. > - > > Moved public var dataGroup:DataGroup; from SkinnableComponent to > ListBase. > - > > There are various existing layout bugs in components, and those are > still reflected in DataGroup / SkinnableDataContainer, of course. > - > > While DataGroup is laying out subcontainers very well, > SkinnableDataContainer is not. For many uses, you can work around by using > "DataGroup" instead of "SkinnableDataContainer" (the MXML, for example, > stays the same, with the dataProvider and such). But of course it would be > nice to get SkinnableDataContainer working properly. SkinnableContainer > does not have the same issue (though it has other issues). Not sure if List > has the issue. > > ------------------------------ > You can view, comment on, or merge this pull request online at: > > https://github.com/apache/royale-asjs/pull/992 > Commit Summary > > - Implement Spark SkinnableDataContainer, reconfigure DataGroup, > adjust List, and add SelfItemRendererInitializer. > > File Changes > > - *M* frameworks/projects/SparkRoyale/src/main/resources/defaults.css > <https://github.com/apache/royale-asjs/pull/992/files#diff-b058f3be2e770f5f03bdbf1fd8631e79adfc2d3aa2323efe88916c52b69613dc> > (39) > - *M* > frameworks/projects/SparkRoyale/src/main/resources/spark-royale-manifest.xml > <https://github.com/apache/royale-asjs/pull/992/files#diff-72e16eca8e57cbb8eaa03e676ad814dd016e9ad33d8c76ce239e97fe54cad543> > (4) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/SparkRoyaleClasses.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-1b34adf23801758fc843cf90ef7a2123ca92c9e494f0d685a6679656fcbd60cf> > (2) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/SkinnableDataContainer.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-bfa76aa100f9593cd4be40e744ce7a65dd9bf7cf6e8c44f97789eb632528b90d> > (285) > - *A* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/VirtualVDataGroup.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-9740e8d3f55a6d41a416ad34efa1afbba42b36939053d272bbe731abea180089> > (49) > - *A* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SelfItemRenderer.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-aa564321d9d6e39355cc4e6fa99182bfcd649645e311096665a03ce748f698d8> > (52) > - *A* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SelfItemRendererInitializer.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-fdb3949acf88b32777656e1221c073d21d6db14e1432cf6c82f5e4169468bc81> > (88) > - *A* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SkinnableDataContainerView.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-821a40dbf63ef5d1759a045aae0a69c012a867d0f86aab806041ced81272fa77> > (143) > - *A* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkDataContainerView.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-90c32615b7872832dfda0902f94c8e29096161b5b7665f0e829df8e7b0be08c2> > (130) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinScrollingViewport.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-e0d51daa09abae2ac194c95e738b0fd4937313271b8df849e87623651b8acf63> > (1) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/beads/SparkSkinViewport.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-79ec26253bd2a875e77ccec370de53afc64bc98848518fd059f8a8c0ee36ac73> > (40) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/ListBase.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-62fa3efbc8bf3cea3106e1f9c8825a226705a326ff80584464f6f94f2c1f0556> > (18) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/components/supportClasses/SkinnableComponent.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-97aef87c0839705178c77b1f4e419d1c445ce2a4e5cd3af3272ad3e19f96c6b6> > (13) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/HorizontalLayout.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-6e8f3e36da690addd45ab5729c2a1d37c9a9d87c1ec39953474be9a394f67613> > (2) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/VerticalLayout.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-a002af10900ff1d1ba66dfa0dc8d74cdc0cb44f55a9c06cd9aaee45971cde171> > (2) > - *M* > frameworks/projects/SparkRoyale/src/main/royale/spark/layouts/supportClasses/SparkLayoutBead.as > <https://github.com/apache/royale-asjs/pull/992/files#diff-8e2e445d1f850f16eba2c14dfa1b7d42e30324ff5f3a2922cd7216f1704b55be> > (3) > > Patch Links: > > - https://github.com/apache/royale-asjs/pull/992.patch > - https://github.com/apache/royale-asjs/pull/992.diff > > — > You are receiving this because you are subscribed to this thread. > Reply to this email directly, view it on GitHub > <https://github.com/apache/royale-asjs/pull/992>, or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AC3RFXJSZ7AVPYDNNTYAIALST4DURANCNFSM4US7BRFA> > . > -- Andrew Wetmore Technical Writer-Editor Infra *Apache Software Foundation* [email protected] ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
