estanglerbm commented on pull request #969: URL: https://github.com/apache/royale-asjs/pull/969#issuecomment-751677021
Test-related: - Implemented XML notifications textSet, namespaceAdded, and namespaceSet - Added addNamespaceInternal() to help implement namespaceAdded notification in a reentrant way Non-test-related: - Fixed a type returned in nameSet notification - Fixed order of nodeRemoved notifications in some cases of setChild(), to match Flex behavior. It turns out that Flex lies in the timing of these notifications; it will send out nodeRemoved notifications _before_ setChild() has actually removed the nodes, at least in some cases. Now, only one test is failing in XMLNotificationTest, and that's related to nodeChanged, which is not implemented yet. (namespaceRemoved is also not implemented yet.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
