SemiConscious opened a new pull request #1023: URL: https://github.com/apache/royale-asjs/pull/1023
This fix attempts to fix two problems I found when when making calls to our AMF service: 1) pass in the AMF URI, as currently it's always NULL, and set it in the messageBody 2) fix the 'params' parameter in AMFNetConnection.call, as otherwise it's not possible to send in an array of optional parameters My main concern in committing this back to the repo is that it changes the signature of `AMFNetConnection.call()`. This is only one solution to the problem. It may be possible to fix the issue by using `.apply()` on the call to that function from `NetConnection.call()` - I will investigate it but I think it would still require some contortions in `AMFNetConnection.call()` to get the desired effect. The other thing to consider is that `NetConnection.call()` has a different signature in royale compared to flex. I assume this was done for a reason so I didn't change that ... but it matches `AMFNetConnection.call()`. If not then reverting to the flex signature would make existing AMF services easier to port. Anyway, by all means have a look and let me know your thoughts. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
