estanglerbm commented on pull request #1046: URL: https://github.com/apache/royale-asjs/pull/1046#issuecomment-759256952
FYI, presentationModel.rowHeight is a fixed constant used in place of measuring actual row height in several places, such as VirtualListVerticalLayout and ListItemRendererInitializer. So it shows up in Spark List and Spark TabBar and other places (not just Spark). It makes a big difference for virtualized layouts, like for Spark List, that will take the available space and divide by this number. (In ADG, things are modified a bit.) Actually, I retract my change on this; 18 is fine for now (at least for the current font). The problem in TabBar is that the button faces on the tabs add a border and such. I'll fix it another way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
