SemiConscious opened a new pull request #1053:
URL: https://github.com/apache/royale-asjs/pull/1053


   Adds functionality marked 'todo' in the source.
   
   There are 2 data encodings used by AMF: AMF0 and AMF3. Royale supports AMF3 
by default and AMF0 via the AMF0AMF3Context bead. There is a complication in 
the AMF0 encoding, which is that it can upgrade from AMF0 to AMF3 midway 
through a read (or write), and this change implements that for reads.
   
   I also added an override of the base class reset function which switches the 
`switchedToAMF3` state variable back to false if `reset()` is called, so in the 
future if the code is extended to handle multiple reads it should call 
`reset()` at the beginning of each read.
   
   This has been tested against the existing unit tests, and our (my 
employer's) production AMF service which requires every combination you can 
think of, including AMF0->AMF3 upgrade.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to