carlosrovira commented on issue #1074: URL: https://github.com/apache/royale-asjs/issues/1074#issuecomment-776644813
Hi Bilbo, yeah, it seems there's some issue in your CSS. Lets see if we find the issue. I can confirm that all is ok at framework level. For what you say, it seems you already have the new bits since the piece of code is the generated CSS from the SASS I posted earlier, so you have it too. So this makes me think that there's something on your side that is causing the problem. Could be a) a browser cache problem or b) a config in compilation problem. a) is easy to check by clearing your browser's cache and reloading to see if all is going ok now. Or trying other browser where you don't test it already. b) SimpleCSSValuesImpl is ok (You can see that's what we use in TDJ). The CSS changed for HSlider and for ToggleButtonBar are not in the theme since are considered "structure", not something "themeable". Just notice that in Jewel we separate CSS in "structure" and in "theme" so we have in theme projects the things we really can change for a different look and feel like colors, borders, backgrounds, and more..... In resume, both latest changes are in Jewel css. Since you are building and seeing the changes in you debug's "App.css" final css, all seems to be ok in your build. You as well will be seeing other styles from the theme you choose (flat-primary-shappire) inside App.css. So all seems to be ok from the info you provided Side Note: if you want to change something from the theme you add a new CSS at your project level and can "override" styles. The Royale compiler will compile all css but will choose yours over the framework's lines and compose a final App.css, so App defined css is always preferred over the same css rule in framework libs. So, from the actual info, I think is a cache problem. If not please let me know a will continue dicarding until we reach the problem. About building: I'm using Maven build since I prefer depend on a build system instead of any IDE to ensure my build is consistent from my desktop development environment to any CI server out there. So I don't use VSCode to build, just use it for code intelligence and to catch errors when coding, but that should not be a problem. Also I remember Josh added the option to add more than one CSS as an Array, just say this so you can check that line and try different things. In Jewel you usually add 3 themes one for primary, one for secondary and one for emphasized. All of this shouldn't have to be anything with your problem, but just for your info. Let's see if we find the issue... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
