[GitHub] [royale-asjs] mjesteve opened a new pull request #1153: Jewel VirtualComboBox only recognises itemRenderers assigned via className

Mon, 27 Sep 2021 17:22:28 -0700 


mjesteve opened a new pull request #1153:
URL: https://github.com/apache/royale-asjs/pull/1153


   Those set through property "itemRenderer" in the mxml tag are not recognised.
   
   It can be checked in the TDJ. If we change the mapping of the ItemRenderer 
in the VirtualComboBox of the VirtualListsPlayGround.mxml view from className 
to itemRenderer tag.
   
   This is how it is now:
   
   
![image](https://user-images.githubusercontent.com/55754195/135001896-70f67cce-f19f-4f9c-a1d2-4404c3095110.png)
   
![image](https://user-images.githubusercontent.com/55754195/135001967-1f3672d5-7f71-455c-b8bd-5a62bab33d35.png)
   
   The result is:
   
   
![image](https://user-images.githubusercontent.com/55754195/135002290-333cdc38-6b27-42f0-9086-ff326993133e.png)
   
   
   If we change it to:
   
![image](https://user-images.githubusercontent.com/55754195/135001722-50ec5f5c-edf6-4b12-abcd-dc451f67da79.png)
   
   The result is:
   
![image](https://user-images.githubusercontent.com/55754195/135002225-c467b11a-fc9f-4d5d-bf1d-4c93a42e32e3.png)
   
   I have located the problem in VirtualComboBoxPopUpView by overriding the 
function "get list". When creating the List associated to the dropdown/popup 
the itemRenderer assigned to the VirtualCombobox must be mapped to it.
   (I have replicated the same function of ComboBoxPopUpView)
   
   Are the modifications correct?
   
   Thx.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to