greg-dove commented on pull request #1126: URL: https://github.com/apache/royale-asjs/pull/1126#issuecomment-950256697
I should be in a position to merge this tomorrow, but I also have changes to make subsequent to yours. The subsequent changes will remove the '::' from the qualified name in "builtin.as$0::MethodClosure" for both swf and js, and all the tests you added (and commented) will be uncommented and passing, as well as some additional tests. The Royale reflection library is not a direct emulation of the native xml (or json) flash reflection data, although it is close for the individual function calls (getQualifiedClassName, getDefinitionByName etc) that correspond. However one of the differences is this '::' in the qualified names. So there is an argument for consistency to not introduce that for one specific case (which for method closures is also quite an outlier). So in this case, the same change then applies anywhere if porting old code (swap '::' for '.' in strings to compare against). Are you ok with '.' instead of '::' in the final implementation, on that basis? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
