Kontinuation commented on PR #913:
URL: https://github.com/apache/sedona/pull/913#issuecomment-1647401533

   > @Kontinuation Since @iGN5117 is adding new dependencies to the Pipfile. 
Does he also need to add keplerGl and pydeck dependecies to `setup.py`? This 
way, when the users do `pip install`, these two libraries will be auto 
installed.
   
   It is more appropriate to make `keplergl` and `pydeck` optional dependencies 
and add them to `extras_require`. If we are intentionally making them 
mandatory, then we should add them to `install_requires`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to