iGN5117 commented on code in PR #960:
URL: https://github.com/apache/sedona/pull/960#discussion_r1291755947
##########
common/src/test/java/org/apache/sedona/common/raster/RasterAccessorsTest.java:
##########
@@ -201,6 +201,23 @@ public void testGridCoordXLonLat() throws
FactoryException, TransformException {
assertEquals(expectedX, actualX);
}
+ @Test
+ public void testSkewX() throws FactoryException {
+ GridCoverage2D emptyRaster = RasterConstructors.makeEmptyRaster(10, 2,
4, 6, 4, 1, 1, 2, 7, 0);
+ assertEquals(2, RasterAccessors.getSkewX(emptyRaster), 0.1d);
Review Comment:
Please add tests testing the convenience constructor of MakeEmptyRaster with
0 skews
##########
docs/api/sql/Raster-operators.md:
##########
@@ -172,6 +172,46 @@ Output:
-2
```
+### RS_SkewX
+
+Introduction: Returns the X skew or rotation parameter.
+
+Format: `RS_SkewX(raster: Raster)`
+
+Since: `v1.5.0`
+
+Spark SQL Exmaple:
+
+```sql
+SELECT RS_SkewX(raster) FROM rasters
+```
+
+Output:
+
+```
+0.1
+```
+
+### RS_SkewY
+
+Introduction: Returns the Y skew or rotation parameter.
+
+Format: `RS_SkewY(raster: Raster)`
+
+Since: `v1.5.0`
+
+Spark SQL Exmaple:
+
+```sql
+SELECT RS_SkewY(raster) FROM rasters
Review Comment:
Please use RS_MakeEmptyRaster in SQL examples so that the skew of the
created raster in visible as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
