jiayuasu commented on code in PR #964: URL: https://github.com/apache/sedona/pull/964#discussion_r1293782371
########## core/src/test/resources/raster/raster_with_no_data/test5.TIFF: ########## Review Comment: This file should not be added. ########## docs/api/sql/Raster-operators.md: ########## @@ -676,7 +676,7 @@ Introduction: Add a band to a raster from an array of doubles. Format: `RS_AddBandFromArray (raster: Raster, band: Array[Double])` | `RS_AddBandFromArray (raster: Raster, band: Array[Double], bandIndex:Int)` | `RS_AddBandFromArray (raster: Raster, band: Array[Double], bandIndex:Int, noDataValue:Double)` -Since: `v1.4.1` +Since: `v1.5.0` Review Comment: You can separate the new APIs and old APIs by ``` Additional APIs since `v1.5.0` XXXX ``` ########## docs/api/sql/Raster-operators.md: ########## @@ -692,6 +692,9 @@ In order to remove an existing noDataValue from an existing band, pass null as t Note that: `bandIndex == RS_NumBands(raster) + 1` is an experimental feature and might not lead to the loss of raster metadata and properties such as color models. +!!!Note + RS_BandFromArray typecasts the double band values to the given datatype of the raster. This can lead to overflow values if values beyond the range of the raster's datatype are provided. Review Comment: This should be `RS_AddBandFromArray`. What can users do to find the current data type in the raster? ########## docs/api/sql/Raster-operators.md: ########## @@ -692,6 +692,9 @@ In order to remove an existing noDataValue from an existing band, pass null as t Note that: `bandIndex == RS_NumBands(raster) + 1` is an experimental feature and might not lead to the loss of raster metadata and properties such as color models. Review Comment: This should be `might lead to` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
