Kontinuation commented on code in PR #1001:
URL: https://github.com/apache/sedona/pull/1001#discussion_r1316641946
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala:
##########
@@ -100,6 +100,10 @@ object InferrableType {
new InferrableType[Array[Byte]] {}
implicit val longArrayInstance: InferrableType[Array[java.lang.Long]] =
new InferrableType[Array[java.lang.Long]] {}
+ implicit val intArrayInstance: InferrableType[Array[Int]] =
+ new InferrableType[Array[Int]] {}
+ implicit val javaIntArrayInstance: InferrableType[Array[java.lang.Integer]] =
Review Comment:
Scala `Int` is a primitive type, which is different from
`java.lang.Integer`. It is necessary to have distinct InferrableType instances
for both `Array[Int]` and `Array[java.lang.Integer]` to support passing `int`
and `int[]` parameters.
##########
spark/common/src/main/scala/org/apache/spark/sql/sedona_sql/expressions/InferredExpression.scala:
##########
@@ -100,6 +100,10 @@ object InferrableType {
new InferrableType[Array[Byte]] {}
implicit val longArrayInstance: InferrableType[Array[java.lang.Long]] =
new InferrableType[Array[java.lang.Long]] {}
+ implicit val intArrayInstance: InferrableType[Array[Int]] =
+ new InferrableType[Array[Int]] {}
+ implicit val javaIntArrayInstance: InferrableType[Array[java.lang.Integer]] =
Review Comment:
Scala `Int` is a primitive type, which is different from
`java.lang.Integer`. It is necessary to have distinct InferrableType instances
for `Array[Int]` and `Array[java.lang.Integer]` to support passing `int` and
`int[]` parameters.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
