jiayuasu commented on code in PR #1056: URL: https://github.com/apache/sedona/pull/1056#discussion_r1369425185
########## python/Pipfile: ########## @@ -14,7 +14,7 @@ pytest-cov = "*" shapely="<=1.8.5" pandas="<=1.3.5" geopandas="<=0.10.2" -pyspark=">=2.3.0" +pyspark="*" Review Comment: Please change this to pyspark=">=3.0.0" ########## examples/spark-viz/build.sbt: ########## @@ -39,7 +39,7 @@ val SparkCompatibleVersion = "3.0" val HadoopVersion = "2.7.2" Review Comment: SeondaViz package is no longer available. The correct dependency should be `sedona-spark-3.0` ########## binder/ApacheSedonaRaster.ipynb: ########## Review Comment: This notebook does not work. It still uses old `geotiff` API that has been dropped. We should remove example for old MapAlgebra functions and use the whole new pipeline we design in 1.5.0 ########## binder/ApacheSedonaSQL.ipynb: ########## Review Comment: This notebook is not working in Binder ########## binder/ApacheSedonaSQL_SpatialJoin_AirportsPerCountry.ipynb: ########## Review Comment: KeplerGL is not shown in all output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
